Core Contracts Release 3

I tend to agree with this separation of concerns. In fact, I left similar comments on the feature PR.

We just received the audit report for release 3 back from OpenZeppelin and they flagged the same low severity issue. Unfortunately the report is currently private, but below is the relevant excerpt:

The grace_period variable of the calculateEpochScore function in the Validators contract is hardcoded and it’s not possible to set it again to another value once the contract is deployed.
To improve flexibility and efficiency of the code base, consider implementing it in such a way that the governance can change its value without re-deploying the contract again.

I recommend we use the audit response as an opportunity to make this parameter governable.

3 Likes